Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configuring number of threads for parallel test execution #831

Closed
cptartur opened this issue Oct 6, 2023 · 6 comments
Closed

Support configuring number of threads for parallel test execution #831

cptartur opened this issue Oct 6, 2023 · 6 comments
Labels
blocked feature New feature request/description snforge

Comments

@cptartur
Copy link
Member

cptartur commented Oct 6, 2023

Blocked by #901

@cptartur cptartur converted this from a draft issue Oct 6, 2023
@github-actions github-actions bot added the new label Oct 6, 2023
@cptartur cptartur moved this from Triage to TODO in Starknet foundry Oct 10, 2023
@cptartur cptartur added feature New feature request/description and removed blocked labels Oct 10, 2023
@piotmag769 piotmag769 linked a pull request Oct 16, 2023 that will close this issue
5 tasks
@piotmag769 piotmag769 moved this from TODO to In Progress in Starknet foundry Oct 16, 2023
@MaksymilianDemitraszek
Copy link
Member

@cptartur Nobody is assigned here though it is in progress

@cptartur
Copy link
Member Author

@cptartur Nobody is assigned here though it is in progress

It's not possible to assign people from outside of the organization who haven't commented on the issue.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Starknet foundry Oct 16, 2023
@cptartur
Copy link
Member Author

cptartur commented Oct 17, 2023

#888 did not resolve this. See #899 for details.

@cptartur cptartur reopened this Oct 17, 2023
@github-project-automation github-project-automation bot moved this from Done to Triage in Starknet foundry Oct 17, 2023
@cptartur cptartur moved this from Triage to Backlog in Starknet foundry Oct 17, 2023
@cptartur cptartur moved this from Backlog to TODO in Starknet foundry Oct 17, 2023
@cptartur cptartur removed a link to a pull request Oct 17, 2023
5 tasks
@cptartur cptartur added new and removed new labels Oct 17, 2023
@cptartur cptartur self-assigned this Oct 18, 2023
@cptartur cptartur moved this from TODO to In Progress in Starknet foundry Oct 18, 2023
@cptartur cptartur removed their assignment Oct 18, 2023
@cptartur cptartur moved this from In Progress to TODO in Starknet foundry Oct 18, 2023
@cptartur
Copy link
Member Author

Tokio's Builder doesn't seem to expose any config for limiting number of cores for blocking and non-blocking tasks at the same time. These are separate configurations and a non-zero amount of cores has to be assigned to both.

Perhaps once #901 is resolved, limiting just non-blocking threads will be enough for us.

@MaksymilianDemitraszek
Copy link
Member

I would like to mention that current design of the architecure requires at least two threads so I would restrain from allowing single thread execution.

@cptartur cptartur moved this from TODO to Triage in Starknet foundry Oct 27, 2023
@cptartur cptartur moved this from Triage to Backlog in Starknet foundry Dec 7, 2023
@cptartur cptartur moved this from Backlog to Triage in Starknet foundry Dec 7, 2023
@Arcticae Arcticae moved this from Triage to Backlog in Starknet foundry Mar 25, 2024
@Arcticae Arcticae moved this from Backlog to Triage in Starknet foundry May 22, 2024
@Arcticae
Copy link
Contributor

Closing because of the latter comment

@Arcticae Arcticae closed this as not planned Won't fix, can't repro, duplicate, stale May 22, 2024
@github-project-automation github-project-automation bot moved this from Triage to Done in Starknet foundry May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked feature New feature request/description snforge
Projects
Archived in project
Development

No branches or pull requests

3 participants