Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate how to remove spawn_blocking from forge code #901

Closed
cptartur opened this issue Oct 17, 2023 · 2 comments · Fixed by #2831
Closed

Investigate how to remove spawn_blocking from forge code #901

cptartur opened this issue Oct 17, 2023 · 2 comments · Fixed by #2831
Assignees

Comments

@cptartur
Copy link
Member

No description provided.

@cptartur cptartur converted this from a draft issue Oct 17, 2023
@github-actions github-actions bot added the new label Oct 17, 2023
@cptartur cptartur removed the new label Oct 17, 2023
@piotmag769
Copy link
Member

https://stackoverflow.com/a/62536772
In short: there is no way to spawn a runtime from a runtime, tokio seems to check that. That's why we have to use spawn blocking which uses another thread pool. However we can try to use Handle to avoid creating additional runtimes
https://docs.rs/tokio/latest/tokio/runtime/struct.Handle.html#method.spawn

@MaksymilianDemitraszek
Copy link
Member

We could consider either implementing some sophisticated strategy of collecting the required data and then batching requests together. Though in my opinion this is not worth the effort atm. Otherwise we would need an async cairo vm which is not feasible.

@Draggu @Arcticae closing it for now as I don't think it will worth the effort.

@MaksymilianDemitraszek MaksymilianDemitraszek closed this as not planned Won't fix, can't repro, duplicate, stale Mar 26, 2024
@github-project-automation github-project-automation bot moved this from TODO to Done in Starknet foundry Mar 26, 2024
@Draggu Draggu reopened this Jan 8, 2025
Draggu added a commit that referenced this issue Jan 8, 2025
Close #901

commit-id:8385f704
Draggu added a commit that referenced this issue Jan 8, 2025
Close #901

commit-id:8385f704
github-merge-queue bot pushed a commit that referenced this issue Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants