Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing Cairo core implicits to BUILTINS #2420

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Added missing Cairo core implicits to BUILTINS #2420

merged 1 commit into from
Sep 2, 2024

Conversation

integraledelebesgue
Copy link
Member

Closes #2397

Introduced changes

  • Added missing implicits present in Cairo core but not ignored by forge-runner: RangeCheck96, AddMod, MulMod

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

piotmag769
piotmag769 reviewed Aug 29, 2024
View reviewed changes
Copy link
Member

@piotmag769 piotmag769 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests, implementation wise looks good from my side

@feltroidprime
Copy link

feltroidprime commented Sep 1, 2024 •
edited
Loading

Please add tests, implementation wise looks good from my side

It looks good please merge it so I can finally profile my code after three months of blind development :D

@piotmag769
Copy link
Member

@integraledelebesgue please add tests in another PR after you come back

@piotmag769 piotmag769 added this pull request to the merge queue Sep 2, 2024
@Arcticae Arcticae mentioned this pull request Sep 2, 2024
Closed
@Arcticae
Copy link
Contributor

Arcticae commented Sep 2, 2024

#2437

Merged via the queue into master with commit 6255060 Sep 2, 2024
14 checks passed
@piotmag769 piotmag769 deleted the integraledelebesgue/fix-2397 branch September 2, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotmag769 piotmag769 piotmag769 left review comments

@Arcticae Arcticae Arcticae approved these changes

@ksew1 ksew1 Awaiting requested review from ksew1

@cptartur cptartur Awaiting requested review from cptartur cptartur is a code owner

@ddoktorski ddoktorski Awaiting requested review from ddoktorski ddoktorski is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate tests compilation failing when using code from core::internal
4 participants
@integraledelebesgue @feltroidprime @piotmag769 @Arcticae