Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate snforge_std to edition 2024_07 #2691

Merged
merged 28 commits into from
Dec 13, 2024
Merged

Migrate snforge_std to edition 2024_07 #2691

merged 28 commits into from
Dec 13, 2024

Conversation

kkawula
Copy link
Collaborator

@kkawula kkawula commented Nov 19, 2024 •
edited
Loading

Closes #2638

Introduced changes

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@kkawula kkawula marked this pull request as ready for review November 25, 2024 11:30
@kkawula kkawula mentioned this pull request Dec 2, 2024
Closed
@kkawula kkawula marked this pull request as draft December 8, 2024 18:51
@kkawula kkawula marked this pull request as ready for review December 9, 2024 07:45
cptartur
cptartur requested changes Dec 9, 2024
View reviewed changes
snforge_std/src/cheatcodes.cairo Outdated Show resolved Hide resolved
snforge_std/src/cheatcodes/events.cairo Outdated Show resolved Hide resolved
snforge_std/src/cheatcodes/execution_info.cairo Outdated Show resolved Hide resolved
snforge_std/src/cheatcodes/execution_info.cairo Outdated Show resolved Hide resolved
snforge_std/src/cheatcodes/execution_info.cairo Outdated Show resolved Hide resolved
snforge_std/src/cheatcodes/l1_handler.cairo Outdated Show resolved Hide resolved
snforge_std/src/cheatcodes/message_to_l1.cairo Outdated Show resolved Hide resolved
snforge_std/src/cheatcodes/storage.cairo Show resolved Hide resolved
snforge_std/src/fs/file_operations.cairo Outdated Show resolved Hide resolved
snforge_std/src/_cheatcode.cairo Show resolved Hide resolved
@kkawula kkawula force-pushed the kkawula/2638-migrate-snforge_std-to-edition-2024_07 branch from 9691779 to 6d6aa4b Compare December 10, 2024 17:55
@kkawula kkawula force-pushed the kkawula/2638-migrate-snforge_std-to-edition-2024_07 branch 3 times, most recently from dc56654 to 9349fcf Compare December 10, 2024 19:31
@kkawula kkawula requested a review from cptartur December 10, 2024 20:55
@cptartur cptartur requested a review from Draggu December 13, 2024 10:05
cptartur
cptartur requested changes Dec 13, 2024
View reviewed changes
crates/forge/tests/integration/runtime.rs Outdated Show resolved Hide resolved
crates/forge/tests/integration/cheat_execution_info.rs Outdated Show resolved Hide resolved
Draggu
Draggu requested changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@Draggu Draggu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that after making parts of it private, it is hard to test, but please create an issue to research ways of testing private parts of snforge_std. Also, keep these tests with #[ignore] instead of removing them entirely.

Draggu
Draggu reviewed Dec 13, 2024
View reviewed changes
crates/forge/tests/integration/test_state.rs Show resolved Hide resolved
snforge_std/src/_cheatcode.cairo Show resolved Hide resolved
snforge_std/src/lib.cairo Outdated Show resolved Hide resolved
@kkawula kkawula force-pushed the kkawula/2638-migrate-snforge_std-to-edition-2024_07 branch from 49f8a90 to 48cb1e6 Compare December 13, 2024 11:18
@kkawula kkawula requested a review from cptartur December 13, 2024 12:42
cptartur
cptartur approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@cptartur cptartur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ ✅ ✅ ✅

@kkawula kkawula added this pull request to the merge queue Dec 13, 2024
Merged via the queue into master with commit 3b71dd4 Dec 13, 2024
26 checks passed
@kkawula kkawula deleted the kkawula/2638-migrate-snforge_std-to-edition-2024_07 branch December 13, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Draggu Draggu Draggu approved these changes

@cptartur cptartur cptartur approved these changes

@ddoktorski ddoktorski Awaiting requested review from ddoktorski ddoktorski is a code owner

@franciszekjob franciszekjob Awaiting requested review from franciszekjob franciszekjob is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate snforge_std to edition 2024_07
3 participants
@kkawula @cptartur @Draggu