Fix .gitattributes to correctly handle binary files
#2839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkawula
requested review from
cptartur,
ddoktorski and
franciszekjob
as code owners
cptartur
approved these changes
Jan 14, 2025
franciszekjob
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Binary files should be excluded from line-ending normalization. In the current state, git is trying to normalize binary files that do not have eol char (and never had). This causes a newly cloned repo to have all binary files unstaged with warning
CRLF will be replaced by LF the next time Git touches it. It may cause confusion in the upcoming hackathon.Introduced changes
Checklist
CHANGELOG.md