Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused dependencies #2845

Merged
merged 3 commits into from
Jan 13, 2025
Merged

Remove unused dependencies #2845

merged 3 commits into from
Jan 13, 2025

Conversation

kkawula
Copy link
Collaborator

@kkawula kkawula commented Jan 13, 2025 •
edited
Loading

Closes #

Introduced changes

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@kkawula kkawula marked this pull request as ready for review January 13, 2025 11:55
Draggu
Draggu requested changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@Draggu Draggu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change title to Remove unused dependencies, when you call it imports it looks like use statements.

@kkawula kkawula changed the title Remove unused imports Remove unused dependencies Jan 13, 2025
ksew1
ksew1 approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@ksew1 ksew1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @kkawula! We really appreciate your contribution to starknet-foundry!!🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥

@kkawula kkawula added this pull request to the merge queue Jan 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 13, 2025
@kkawula kkawula enabled auto-merge January 13, 2025 19:18
@kkawula kkawula added this pull request to the merge queue Jan 13, 2025
Merged via the queue into master with commit 763ad5b Jan 13, 2025
38 checks passed
@kkawula kkawula deleted the kkawula/remove-unused-imports branch January 13, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksew1 ksew1 ksew1 approved these changes

@Draggu Draggu Draggu approved these changes

@franciszekjob franciszekjob franciszekjob approved these changes

@cptartur cptartur Awaiting requested review from cptartur cptartur is a code owner

@ddoktorski ddoktorski Awaiting requested review from ddoktorski ddoktorski is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kkawula @franciszekjob @Draggu @ksew1