Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hardcoded default ability scores #1846

Closed
arbron opened this issue Oct 6, 2022 · 0 comments · Fixed by #1847
Closed

Remove hardcoded default ability scores #1846

arbron opened this issue Oct 6, 2022 · 0 comments · Fixed by #1847
Assignees
@arbron
Labels
api
Milestone
D&D5E 2.2.0

Comments

@arbron
Copy link
Collaborator

arbron commented Oct 6, 2022

Currently, ability scores all default to 10 except in a few cases where there are hardcoded exceptions like vehicle mental scores defaulting to 0 and Honor & Sanity on NPCs defaulting to equal Charisma and Wisdom by default. It would be useful to move these defaults into configuration so new abilities can specify their own defaults or the core ones can be overridden.
@arbron arbron added the api label Oct 6, 2022
@arbron arbron self-assigned this Oct 6, 2022
arbron added a commit to arbron/dnd5e that referenced this issue Oct 6, 2022
@arbron
[foundryvtt#1846] Convert DND5E.abilities to object, replace references
4f8b5a7
arbron added a commit to arbron/dnd5e that referenced this issue Oct 6, 2022
@arbron
[foundryvtt#1846] Add ability score defaults to config
23ebe96
@arbron arbron mentioned this issue Oct 6, 2022
Merged
@arbron arbron linked a pull request Oct 6, 2022 that will close this issue
[#1846] Allow ability type & defaults to be defined in config #1847
Merged
arbron added a commit to arbron/dnd5e that referenced this issue Oct 13, 2022
@arbron
[foundryvtt#1846] Convert DND5E.abilities to object, replace references
be511f7
arbron added a commit to arbron/dnd5e that referenced this issue Oct 13, 2022
@arbron
[foundryvtt#1846] Add ability score defaults to config
40b38d8
arbron added a commit to arbron/dnd5e that referenced this issue Dec 21, 2022
@arbron
[foundryvtt#1846] Convert DND5E.abilities to object, replace references
f9ce3fa
arbron added a commit to arbron/dnd5e that referenced this issue Dec 21, 2022
@arbron
[foundryvtt#1846] Add ability score defaults to config
1a16177
arbron added a commit to arbron/dnd5e that referenced this issue Jan 26, 2023
@arbron
[foundryvtt#1846] Convert DND5E.abilities to object, replace references
84f8608
arbron added a commit to arbron/dnd5e that referenced this issue Jan 26, 2023
@arbron
[foundryvtt#1846] Add ability score defaults to config
34a90c6
@arbron arbron added this to the D&D5E 2.2.0 milestone Jan 26, 2023
arbron added a commit that referenced this issue Jan 26, 2023
@arbron
Merge pull request #1847 from arbron/config/abilities
eb8f2a4 
[#1846] Allow ability type & defaults to be defined in config
@arbron arbron closed this as completed Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arbron arbron

Labels
api
Projects
None yet
Milestone
D&D5E 2.2.0
Development

Successfully merging a pull request may close this issue.

[#1846] Allow ability type & defaults to be defined in config arbron/dnd5e
1 participant
@arbron