Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying type on ability to control how it is handled in Polymorphing #1848

Closed
arbron opened this issue Oct 6, 2022 · 0 comments · Fixed by #1847
Closed

Allow specifying type on ability to control how it is handled in Polymorphing #1848

arbron opened this issue Oct 6, 2022 · 0 comments · Fixed by #1847
Assignees
@arbron
Labels
api
Milestone
D&D5E 2.2.0

Comments

@arbron
Copy link
Collaborator

arbron commented Oct 6, 2022

Currently the list of ability scores that are retained during polymorphing when "Keep Mental Abilities" and "Keep Physical Abilities" are hardcoded, and thus don't support Honor, Sanity, or any custom ability scores. Adding a "type" value to configuration that specifies physical or mental would allow the polymorphing system to respond to these new abilities if desired.
@arbron arbron self-assigned this Oct 6, 2022
@arbron arbron added the api label Oct 6, 2022
arbron added a commit to arbron/dnd5e that referenced this issue Oct 6, 2022
@arbron
[foundryvtt#1848] Add ability types & adjust polymorphing to use them
0270318
@arbron arbron mentioned this issue Oct 6, 2022
Merged
@arbron arbron linked a pull request Oct 6, 2022 that will close this issue
[#1846] Allow ability type & defaults to be defined in config #1847
Merged
arbron added a commit to arbron/dnd5e that referenced this issue Oct 13, 2022
@arbron
[foundryvtt#1848] Add ability types & adjust polymorphing to use them
376c08b
arbron added a commit to arbron/dnd5e that referenced this issue Dec 21, 2022
@arbron
[foundryvtt#1848] Add ability types & adjust polymorphing to use them
4797bef
arbron added a commit to arbron/dnd5e that referenced this issue Jan 26, 2023
@arbron
[foundryvtt#1848] Add ability types & adjust polymorphing to use them
107e140
@arbron arbron added this to the D&D5E 2.2.0 milestone Jan 26, 2023
arbron added a commit to arbron/dnd5e that referenced this issue Jan 26, 2023
@arbron
[foundryvtt#1848] Minor code style adjustment
20c8706
@arbron arbron closed this as completed Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arbron arbron

Labels
api
Projects
None yet
Milestone
D&D5E 2.2.0
Development

Successfully merging a pull request may close this issue.

[#1846] Allow ability type & defaults to be defined in config arbron/dnd5e
1 participant
@arbron