Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crewed/uncrewed toggle button on actions/equipment in vehicle sheets broken on 2.1.4 #2166

Closed
Gawdl3y opened this issue Feb 8, 2023 · 3 comments · Fixed by #2169
Closed
Assignees
Labels
bug Functionality which is not working as intended ui User interface related features or bugs
Milestone

Comments

@Gawdl3y
Copy link
Contributor

Gawdl3y commented Feb 8, 2023

The button to toggle the crewed/uncrewed status of an action or equipment in vehicle sheets does not do anything. No errors are output into the console when clicking it. I have reproduced this on a totally vanilla setup with no modules active and a completely fresh world.

Repro steps:

  1. Create a new vehicle actor
  2. Add an action to it
  3. Click the crewed status toggle button on the new action in the list

image

@krbz999
Copy link
Contributor

krbz999 commented Feb 8, 2023

Seems like item.system.crewed is not a property on items anymore whatsoever. And secondly, the HP of items cannot be edited from the sheet at all either.

@krbz999
Copy link
Contributor

krbz999 commented Feb 8, 2023

Also seems like threshold and cover does not appear at all.

@arbron
Copy link
Collaborator

arbron commented Feb 8, 2023

Seems like item.system.crewed is not a property on items anymore whatsoever. And secondly, the HP of items cannot be edited from the sheet at all either.

Strangely enough system.crewed was never defined in template.json, so it got overlooked in the conversion to data models.

@arbron arbron self-assigned this Feb 8, 2023
@arbron arbron added bug Functionality which is not working as intended ui User interface related features or bugs labels Feb 8, 2023
@arbron arbron added this to the D&D5E 2.2.0 milestone Feb 8, 2023
arbron added a commit to arbron/dnd5e that referenced this issue Feb 8, 2023
@Fyorl Fyorl closed this as completed May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality which is not working as intended ui User interface related features or bugs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants