Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Items with uses.value or uses.max filled in but not uses.per still show as limited uses on the character sheet. If a feature instead has 'recharge', this does not show at all under any circumstances #2930

Closed
krbz999 opened this issue Feb 6, 2024 · 2 comments · Fixed by #3556
Closed

Items with uses.value or uses.max filled in but not uses.per still show as limited uses on the character sheet. If a feature instead has 'recharge', this does not show at all under any circumstances #2930

krbz999 opened this issue Feb 6, 2024 · 2 comments · Fixed by #3556
Assignees
@Hoppyhob
Labels
bug Functionality which is not working as intended
Milestone
D&D5E 3.3.0

Comments

@krbz999
Copy link
Contributor

krbz999 commented Feb 6, 2024

Tested with a feature item.
@Fyorl
Copy link
Contributor

Fyorl commented Feb 6, 2024

The 1d6 recharge mechanic is exclusively for NPCs, so there was deliberately no time spent on it for the character sheets. I expect it will come back purely via code-sharing with the NPC sheets though. That was probably the reason we used bespoke logic for detecting limited uses rather than using Item5e#hasLimitedUses.

@Fyorl Fyorl added the bug Functionality which is not working as intended label Feb 6, 2024
@Fyorl Fyorl added this to the D&D5E 3.0.2 milestone Feb 6, 2024
@Fyorl Fyorl mentioned this issue Feb 26, 2024
Closed
@krbz999 krbz999 mentioned this issue Mar 5, 2024
Closed
@Fyorl Fyorl modified the milestones: D&D5E 3.1.0, D&D5E 3.2.0 Mar 21, 2024
@Hoppyhob
Copy link
Contributor

I can work on this.

Hoppyhob added a commit to Hoppyhob/dnd5e that referenced this issue May 12, 2024
@Hoppyhob
[foundryvtt#2930]Added recharge logic to character-features.hbs
4e97bad 
Added ctx.isOnCooldown and item.system.recharge.value checks from actor-features.hbs
Moved div into the checks and added else to handle the empty case.
closes foundryvtt#2930
@Hoppyhob Hoppyhob mentioned this issue May 12, 2024
Merged
Hoppyhob added a commit to Hoppyhob/dnd5e that referenced this issue May 18, 2024
@Hoppyhob
[foundryvtt#2930]Add Tooltip, Context Menu Toggle, and Icons
26cc237 
Added context menu localization for charge and uncharge
Added fa-arrows-rotate icon for uncharged and fa-bolt icon for charged
Added i.fa-bolt less to use the color gold
Moved isOnCooldown from sheets context to item as it was used in multiple places and outside the sheet context
Added context menu toggle to inventory.js
Added toggleCharge action to inventory.js
Modified handlebars to get isOnCooldown from item instead of context.
@arbron arbron modified the milestones: D&D5E 3.2.0, D&D5E 3.3.0 May 20, 2024
@Fyorl Fyorl assigned Hoppyhob and unassigned Fyorl Jul 1, 2024
Fyorl pushed a commit to Hoppyhob/dnd5e that referenced this issue Jul 1, 2024
@Hoppyhob @Fyorl
[foundryvtt#2930]Added recharge logic to character-features.hbs
c5ccc3b 
Added ctx.isOnCooldown and item.system.recharge.value checks from actor-features.hbs
Moved div into the checks and added else to handle the empty case.
closes foundryvtt#2930
Fyorl pushed a commit to Hoppyhob/dnd5e that referenced this issue Jul 1, 2024
@Hoppyhob @Fyorl
[foundryvtt#2930]Add Tooltip, Context Menu Toggle, and Icons
7b4af3f 
Added context menu localization for charge and uncharge
Added fa-arrows-rotate icon for uncharged and fa-bolt icon for charged
Added i.fa-bolt less to use the color gold
Moved isOnCooldown from sheets context to item as it was used in multiple places and outside the sheet context
Added context menu toggle to inventory.js
Added toggleCharge action to inventory.js
Modified handlebars to get isOnCooldown from item instead of context.
Fyorl added a commit that referenced this issue Jul 1, 2024
@Hoppyhob @Fyorl
[#2930]Added recharge logic to character-features.hbs (#3556)
4566c8d 
Co-authored-by: Kim Mantas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hoppyhob Hoppyhob

Labels
bug Functionality which is not working as intended
Projects
None yet
Milestone
D&D5E 3.3.0
Development

Successfully merging a pull request may close this issue.

[#2930]Added recharge logic to character-features.hbs Hoppyhob/dnd5e
4 participants
@Fyorl @Hoppyhob @arbron @krbz999