Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect parsing of healing / damage formulas with * or / #3596

Closed
davidR1974 opened this issue May 21, 2024 · 0 comments · Fixed by #3905
Closed

Incorrect parsing of healing / damage formulas with * or / #3596

davidR1974 opened this issue May 21, 2024 · 0 comments · Fixed by #3905
Assignees
@arbron
Labels
bug Functionality which is not working as intended
Milestone
D&D5E 4.0.0

Comments

@davidR1974
Copy link

in dnd5 3.1.2, foundry 11.315 with no module enabled, i created an item that deals 5 * (@classes.sorcer.levels) (made the same with healing with same behaviour)

In the corresponding chat card i can see 10 correctly populated but i can also see that +7 on the left tooltip which, according to my tests, always seems to be the formula where every * or / has been replaced by a +

image

image
@Fyorl Fyorl added the bug Functionality which is not working as intended label May 28, 2024
@arbron arbron added this to the D&D5E 4.0.0 milestone Jul 30, 2024
@arbron arbron self-assigned this Jul 30, 2024
arbron added a commit that referenced this issue Jul 30, 2024
@arbron
[#3596] Remove multiplication constant from damage tooltips
674c917 
Since properly summarizing complex operators like multiplication
is hard to do without just showing the whole roll formula, this
simply removes the constant number portion of the damage roll
tooltip if any operators other than addition or subtraction are
found. This still allows the dice rolls to be seen and the total
displays correctly, but removes any potentially confusion values.

Closes #3596
@arbron arbron mentioned this issue Jul 30, 2024
Merged
@arbron arbron closed this as completed in a32f06c Aug 16, 2024
arbron added a commit that referenced this issue Aug 16, 2024
@arbron
Merge pull request #3905 from foundryvtt/damage-tooltip-fix
fdb0030 
[#3596] Remove multiplication constant from damage tooltips
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arbron arbron

Labels
bug Functionality which is not working as intended
Projects
None yet
Milestone
D&D5E 4.0.0
Development

Successfully merging a pull request may close this issue.

[#3596] Remove multiplication constant from damage tooltips foundryvtt/dnd5e
3 participants
@Fyorl @arbron @davidR1974