Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System invalidating roll formulas #3895

Closed
krbz999 opened this issue Jul 26, 2024 · 1 comment
Closed

System invalidating roll formulas #3895

krbz999 opened this issue Jul 26, 2024 · 1 comment
Assignees
@Fyorl
Labels
bug Functionality which is not working as intended system: dice Dice rolling functionality
Milestone
D&D5E 4.0.0

Comments

@krbz999
Copy link
Contributor

krbz999 commented Jul 26, 2024

These work as expected:

  • /r 1d10 + (3/2)
  • /r 1d10 + (floor(3/2))

These throw an error:

  • /r 1d10 + 3/2
  • /r 1d10 + floor(3/2)

image

Tested similar rolls in a different system with zero issues.
@arbron arbron added bug Functionality which is not working as intended system: dice Dice rolling functionality labels Jul 30, 2024
@arbron arbron added this to the D&D5E 4.0.0 milestone Jul 30, 2024
@eelpik
Copy link

eelpik commented Aug 8, 2024

I'll try working on this if that's all right

@eelpik eelpik mentioned this issue Aug 9, 2024
Closed
@Fyorl Fyorl self-assigned this Aug 30, 2024
Fyorl added a commit that referenced this issue Aug 30, 2024
@Fyorl
[#3895] Fix error thrown when simplifying certain roll expressions.
4634d08
@Fyorl Fyorl closed this as completed Aug 30, 2024
@Fyorl Fyorl mentioned this issue Sep 10, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Fyorl Fyorl

Labels
bug Functionality which is not working as intended system: dice Dice rolling functionality
Projects
None yet
Milestone
D&D5E 4.0.0
Development

Successfully merging a pull request may close this issue.

Fix handling of certain rolls that contain division or multiplication eelpik/dnd5e
4 participants
@Fyorl @arbron @krbz999 @eelpik