Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2162, #2185] Fix sheet layout issues with long background or class names #2186

Merged
merged 2 commits into from
May 22, 2023
Merged

[#2162, #2185] Fix sheet layout issues with long background or class names #2186

merged 2 commits into from
May 22, 2023

Conversation

arbron
Copy link
Collaborator

@arbron arbron commented Feb 11, 2023

Screenshot 2023-02-11 at 14 59 30

@arbron arbron added bug Functionality which is not working as intended ui User interface related features or bugs labels Feb 11, 2023
@arbron arbron added this to the D&D5E 2.2.0 milestone Feb 11, 2023
@arbron arbron self-assigned this Feb 11, 2023
@krbz999
Copy link
Contributor

krbz999 commented Feb 11, 2023

I'm normally against adding new css classes where they aren't needed, but could there be a .race, .background, and .alignment class added, to align with their .proficiency sibling?

This was linked to issues May 13, 2023
Longer Character Background Titles Cause Display Issues #2162
Closed
Long class names with multi-classing causes sheet layout issues #2185
Closed
@arbron arbron requested a review from Fyorl May 13, 2023 17:18
Fyorl
Fyorl approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@Fyorl Fyorl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll note that backgrounds with pathologically-long names still break the layout, but I couldn't find a quick fix aside from overflow: hidden which was not ideal.

@Fyorl Fyorl merged commit 8de2e33 into foundryvtt:2.2.x May 22, 2023
@arbron arbron deleted the bugs/background-class-width branch May 22, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fyorl Fyorl Fyorl approved these changes

Assignees

@arbron arbron

Labels
bug Functionality which is not working as intended ui User interface related features or bugs
Projects
None yet
Milestone
D&D5E 2.2.0
3 participants
@arbron @krbz999 @Fyorl