[#5003] Add ability attack, spell attack, & spell ability labels #5004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `attack` to each ability which is the default attack to hit using that ability (e.g. prof + mod). Also adds the spell attack and ability label to actor attributes inside a new `attributes.spells` object. This moves the old `spelldc` and `spellmod` into that object with deprecation warnings. Closes #5003
krbz999
reviewed
Jan 15, 2025
| @@ -149,6 +149,7 @@ export default class CommonTemplate extends ActorDataModel.mixin(CurrencyTemplat | |||
|
|
|||
| abl.save = abl.mod + abl.saveBonus; | |||
| if ( Number.isNumeric(abl.saveProf.term) ) abl.save += abl.saveProf.flat; | |||
| abl.attack = abl.mod + prof; | |||
There was a problem hiding this comment.
If this is meant only for display purposes, should it not rather be a string? A numeric value won't support proficiency dice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
attackto each ability which is the default attack to hit using that ability (e.g. prof + mod).Also adds the spell attack and ability label to actor attributes inside a new
attributes.spellsobject. This moves the oldspelldcandspellmodinto that object with deprecation warnings.Closes #5003