[#4830] Only defer to item abilities if attack activity matches attack type #5007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbron
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would close #4830
When the activity's
attack.abilitywas left to default, it would pull from its item'savailableActivities, meaning that a spell attack on a weapon would use str or dex, and a weapon attack on a spell would use whatever was set on the spell as the spellcasting ability. By only using the parent item'savailableActivitiesif the attack type matches (i.e. weapon attack on a weapon, spell attack on a spell), this problem is avoided without any side effects (to my knowledge).