Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize when last attack is critical and set damage & default button accordingly #5015

Open
wants to merge 1 commit into
base: 4.2.x
Choose a base branch
from

Conversation

roth-michael
Copy link
Contributor

Partially addresses #4968
When rolling damage from an attack activity's chat card, check lastAttack for whether it was a crit. If so, pass isCritical in the config argument and options: { defaultButton: "critical" } in the dialog argument. This way, shift-clicking damage after a crit will roll critical damage, and going through the dialog will show the crit dice & highlight the crit button (similar to the default behavior of advantage/disadvantage for the rolls that currently have that functionality).

@arbron arbron added ux User experience related features or bugs system: activities labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system: activities ux User experience related features or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants