Recognize when last attack is critical and set damage & default button accordingly #5015
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #4968
When rolling damage from an attack activity's chat card, check
lastAttack
for whether it was a crit. If so, passisCritical
in theconfig
argument andoptions: { defaultButton: "critical" }
in thedialog
argument. This way, shift-clicking damage after a crit will roll critical damage, and going through the dialog will show the crit dice & highlight the crit button (similar to the default behavior of advantage/disadvantage for the rolls that currently have that functionality).