Apply remaster theme to select tables in items #17966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonward
reviewed
Jan 11, 2025
| @@ -159,7 +159,7 @@ | |||
| }, | |||
| "category": "offensive", | |||
| "description": { | |||
| "value": "<p><strong>Requirements</strong> The scroungefeather is in its nest or another environment rich with debris</p><hr /><p><strong>Effect</strong> The scroungefeather uses an Interact action to grab an item with its beak, selected randomly; roll 1d4 to determine the type of debris. The scroungefeather gains access to the listed abilities until it uses Tossed Scraps to discard the debris or until it Releases the debris. The scroungefeather can't use its beak attack while it is using its beak to Grab Debris.</p><table class=\"pf2e\"><thead><tr><th>d4</th><th>Item</th><th>Effect</th></tr></thead><tbody><tr><td>1</td><td>Armor scrap</td><td>The scroungefeather gains a +2 circumstance bonus to its AC.</td></tr><tr><td>2</td><td>Shattered blade</td><td>The scroungefeather gains a broken blade melee Strike with a +12 attack modifier that deals 2d10+6 slashing damage.</td></tr><tr><td>3</td><td>Unexploded bomb</td><td>When the scroungefeather throws this with Tossed Scraps, all the damage is fire damage, and the bomb also deals 3 fire splash damage.</td></tr><tr><td>4</td><td>Faulty wand</td><td>The scroungefeather gains a magic bolt ranged Strike witha +14 attack modifier that deals 2d6+6 force damage.</td></tr></tbody></table>" | |||
| "value": "<p><strong>Requirements</strong> The scroungefeather is in its nest or another environment rich with debris</p><hr /><p><strong>Effect</strong> The scroungefeather uses an Interact action to grab an item with its beak, selected randomly; roll [[/gmr 1d4]] to determine the type of debris. The scroungefeather gains access to the listed abilities until it uses Tossed Scraps to discard the debris or until it Releases the debris. The scroungefeather can't use its beak attack while it is using its beak to Grab Debris.</p><table class=\"pf2e remaster\"><thead><tr><th>d4</th><th>Item</th><th>Effect</th></tr></thead><tbody><tr><td>1</td><td>Armor scrap</td><td>The scroungefeather gains a +2 circumstance bonus to its AC.</td></tr><tr><td>2</td><td>Shattered blade</td><td>The scroungefeather gains a broken blade melee Strike with a +12 attack modifier that deals 2d10+6 slashing damage.</td></tr><tr><td>3</td><td>Unexploded bomb</td><td>When the scroungefeather throws this with Tossed Scraps, all the damage is fire damage, and the bomb also deals 3 fire splash damage.</td></tr><tr><td>4</td><td>Faulty wand</td><td>The scroungefeather gains a magic bolt ranged Strike witha +14 attack modifier that deals 2d6+6 force damage.</td></tr></tbody></table>" | |||
There was a problem hiding this comment.
The roll is automated by the effect, so not sure we need the inline roll?
packs/spells/rainbow-fumarole.json
Outdated
| @@ -19,7 +19,7 @@ | |||
| } | |||
| }, | |||
| "description": { | |||
| "value": "<p><strong>Area</strong> 20-foot radius, 60-foot-tall cylinder</p>\n<hr />\n<p>Multi-hued flames break through cracks in the ground, reaching high into the sky and giving off dangerous fumes. When you cast the spell, roll 1d8 on the table below to determine the effects of the fumarole.</p>\n<p>Any creature caught inside the area of <em>rainbow fumarole</em> when you cast it takes the indicated damage with a basic Reflex save and, on a failure, takes any added effect listed. Creatures must also attempt a saving throw when they move through the spell's area or end their turn in it. Squares within the area of the <em>rainbow fumarole</em> are difficult terrain.</p>\n<table class=\"pf2e\">\n<thead>\n<tr>\n<th>[[/r 1d8]]{d8}</th>\n<th>Color</th>\n<th>Damage</th>\n<th>Added Effect</th>\n</tr>\n</thead>\n<tbody>\n<tr>\n<td>1</td>\n<td>Red</td>\n<td>@Damage[50[fire],2d6[persistent,fire]]{50 fire plus 2d6 persistent fire}</td>\n<td>—</td>\n</tr>\n<tr>\n<td>2</td>\n<td>Orange</td>\n<td>@Damage[50[fire]]</td>\n<td>Knocked @UUID[Compendium.pf2e.conditionitems.Item.Prone]</td>\n</tr>\n<tr>\n<td>3</td>\n<td>Yellow</td>\n<td>@Damage[30[fire],20[bludgeoning]]{30 fire plus 20 bludgeoning}</td>\n<td>Pushed 10 feet</td>\n</tr>\n<tr>\n<td>4</td>\n<td>Green</td>\n<td>@Damage[20[fire],20[acid]]{20 fire plus 20 acid}</td>\n<td>@UUID[Compendium.pf2e.conditionitems.Item.Sickened]{Sickened 2}</td>\n</tr>\n<tr>\n<td>5</td>\n<td>Blue</td>\n<td>@Damage[30[fire]]</td>\n<td>@UUID[Compendium.pf2e.conditionitems.Item.Paralyzed] for 1 round</td>\n</tr>\n<tr>\n<td>6</td>\n<td>Indigo</td>\n<td>@Damage[30[fire]]</td>\n<td>@UUID[Compendium.pf2e.conditionitems.Item.Confused] for 1 minute</td>\n</tr>\n<tr>\n<td>7</td>\n<td>Violet</td>\n<td>@Damage[30[fire]]</td>\n<td>@UUID[Compendium.pf2e.conditionitems.Item.Slowed]{Slowed 1} for 1 minute</td>\n</tr>\n<tr>\n<td>8</td>\n<td>All</td>\n<td>Choose the color for each affected creature and use that color's damage and added effect; if a creature is affected again, you can choose a different color.</td>\n<td>—</td>\n</tr>\n</tbody>\n</table>" | |||
| "value": "<p><strong>Area</strong> 20-foot radius, 60-foot-tall cylinder</p><hr /><p>Multi-hued flames break through cracks in the ground, reaching high into the sky and giving off dangerous fumes. When you cast the spell, roll 1d8 on the table below to determine the effects of the fumarole.</p>\n<p>Any creature caught inside the area of <em>rainbow fumarole</em> when you cast it takes the indicated damage with a basic Reflex save and, on a failure, takes any added effect listed. Creatures must also attempt a saving throw when they move through the spell's area or end their turn in it. Squares within the area of the <em>rainbow fumarole</em> are difficult terrain.</p><table class=\"pf2e remaster\"><thead><tr><th>[[/r 1d8]]{d8}</th><th>Color</th><th>Damage</th><th>Added Effect</th></tr></thead><tbody><tr><td>1</td><td>Red</td><td>@Damage[50[fire],2d6[persistent,fire]]{50 fire plus 2d6 persistent fire}</td><td>—</td></tr><tr><td>2</td><td>Orange</td><td>@Damage[50[fire]]</td><td>Knocked @UUID[Compendium.pf2e.conditionitems.Item.Prone]</td></tr><tr><td>3</td><td>Yellow</td><td>@Damage[30[fire],20[bludgeoning]]{30 fire plus 20 bludgeoning}</td><td>Pushed 10 feet</td></tr><tr><td>4</td><td>Green</td><td>@Damage[20[fire],20[acid]]{20 fire plus 20 acid}</td><td>@UUID[Compendium.pf2e.conditionitems.Item.Sickened]{Sickened 2}</td></tr><tr><td>5</td><td>Blue</td><td>@Damage[30[fire]]</td><td>@UUID[Compendium.pf2e.conditionitems.Item.Paralyzed] for 1 round</td></tr><tr><td>6</td><td>Indigo</td><td>@Damage[30[fire]]</td><td>@UUID[Compendium.pf2e.conditionitems.Item.Confused] for 1 minute</td></tr><tr><td>7</td><td>Violet</td><td>@Damage[30[fire]]</td><td>@UUID[Compendium.pf2e.conditionitems.Item.Slowed]{Slowed 1} for 1 minute</td></tr><tr><td>8</td><td>All</td><td>Choose the color for each affected creature and use that color's damage and added effect; if a creature is affected again, you can choose a different color.</td><td>—</td></tr></tbody></table>" | |||
There was a problem hiding this comment.
Is the <td>—</td> at the end intentional?
There was a problem hiding this comment.
Yes, it's for the last option/8, there's no additional effect (also happens in 1)
There was a problem hiding this comment.
Also noticed RoE doesn't apply the remaster green to the tables. Let me revert the color scheme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.