Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blur_faces() error 2 #308

Closed
alexarje opened this issue Nov 14, 2023 · 1 comment
Closed

blur_faces() error 2 #308

alexarje opened this issue Nov 14, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@alexarje
Copy link
Contributor

The latest fix of blur_faces() removed the progress bar but introduced a new error (2)... The blurred video is saved correctly, but it chokes on saving the csv file.
Screenshot_20231114_205321

@alexarje alexarje added the bug Something isn't working label Nov 14, 2023
joachimpoutaraud added a commit that referenced this issue Nov 15, 2023
@joachimpoutaraud
Copy link
Contributor

When fixing the previous issue with the blur_faces(), I did some minor adjustements to the embed_audio_in_video function, but there is apparently still something I am not able to understand properly.

There are parts of the code in the toolbox which are a bit redundant or which do not use functions already available in the toolbox. At some point, it would be great to meet with Balint to do some recap of all the functions available in the toolbox, in order to see if we need to keep them all or do some cleaning (especially in the _utils.py script).

For now, I have fixed the issue related to the progress bar and removed what I did on the embed_audio_in_video function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants