Build CLI with -tags 'netgo' #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default we are relying on cgo for DNS resolution, which causes binaries built on ubuntu 22.04 to break on ubuntu 20.04 due to some changes in glibc. See golang/go#57328 This changes us to not rely on that, which causes builds to succeed.
wkalt
force-pushed
the
ticket/fg-5005/build-cli-without-cgo
branch
from
02d77b4 to
e114287
Compare
bryfox
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default we are relying on cgo for DNS resolution, which causes
binaries built on ubuntu 22.04 to break on ubuntu 20.04 due to some
changes in glibc. See golang/go#57328
This changes us to not rely on that, which causes builds to succeed.