go: fix channel auto coalescing in merge #1322
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Ensure channel auto coalescing is deterministic in
mcap merge
Docs
Description
In the
mcap merge
command, the channel auto coalescing is currently non-deterministic due to the random ordering of iterating over a map in go. This change just sorts the metadata keys before we hash it to ensure for the same channel metadata we always get the same hash.For example, if trying to merge these to mcaps
will sometimes give this
and sometimes give this
I've updated the unit tests to test for this.
Fixes: foxglove/repo#772