cli: Support multiple inputs in 'cat' #1331
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support to the `mcap cat` command for multiple input files.
Multiple files can be directly supplied, like
mcap cat file1.mcap file2.mcap
or, the list of files may be auto-populated by your shell, enabling you
to type
mcap cat **/*.mcap
wkalt
commented
Feb 8, 2025
| // stdin. | ||
| readingStdin := (stat.Mode()&os.ModeCharDevice == 0 && len(args) == 0) | ||
|
|
||
| // stdin is a special case, since we can't seek |
There was a problem hiding this comment.
I rearranged this comment and moved the stdin-related stuff closer together.
|
This seems ok, but I think it deserves a CLI doc change to describe what the behavior is. Before looking at the code and just looking at the PR title, I assumed you were extending Related - do you think it'd be worth supporting a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support to the
mcap catcommand for multiple input files. Multiple files can be directly supplied, likeor, the list of files may be auto-populated by your shell, enabling you to type