-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sqlmodel #934
Update sqlmodel #934
Conversation
Coverage reportThe coverage rate went from None of the new lines are part of the tested code. Therefore, there is no coverage data about them. |
First learning: the breaking (for our CI) change was in sqlmodel/main.py: # sqlmodel 0.0.8
if issubclass(field.type_, str):
if field.field_info.max_length:
return AutoString(length=field.field_info.max_length)
return AutoString
if issubclass(field.type_, Enum):
return sa_Enum(field.type_)
# sqlmodel 0.0.9
if issubclass(field.type_, Enum):
return sa_Enum(field.type_)
if issubclass(field.type_, str):
if field.field_info.max_length:
return AutoString(length=field.field_info.max_length)
return AutoString We have some objects like fractal_server/app/models/job.py:class JobStatusType(str, Enum):
fractal_server/app/schemas/workflow.py:class WorkflowTaskStatusType(str, Enum): which are both Refs:
Why is this relevant for postgres?
|
As of sqlmodel 0.0.11, an error is raised ("Passing nullable is not supported when also passing a sa_column")
Closing in favor of #949 |
Checklist before merging
CHANGELOG.md