Data race warning

[Perlence]

I use goreq to send concurrent requests:

resp, err := goreq.Request{
    Uri: "https://en.wikipedia.org/w/api.php",
    QueryString: url.Values{
        "action": {"opensearch"},
        "search": {query},
    },
}.Do()

But when I checked the program for races, I got this:

WARNING: DATA RACE
Write by goroutine 14:
  github.com/franela/goreq.Request.Do()
      /home/ubuntu/.local/go/src/github.com/franela/goreq/goreq.go:314 +0x6ff

So race detector warns me that goroutines write unsafely into CheckRedirect of DefaultClient.

[marcosnils]

@Perlence can you update goreq and run the race detector again?. Seems like is something else https://github.com/franela/goreq/blob/master/goreq.go#L314

[Perlence]

I've updated goreq so the master is 8f5efc2. Unfortunately warning's still there:

Write by goroutine 14:
  github.com/franela/goreq.Request.Do()
      /home/ubuntu/.local/go/src/github.com/franela/goreq/goreq.go:323 +0x6ff

[marcosnils]

@Perlence We found the issue. We'll be fixing this shorty. It won't affect your code unless you are specifying different maxRedirects per request.

[rhd]

Hi, I'm seeing the same issue - would love a fix just to clean up the warning.

[marcosnils]

@rhd we'll fix it shortly.

[rrh]

I have independently rediscovered this race condition in my application. I'm at head, eg 72c51a5

Note also that changing the Makefile to run go test --race finds other race conditions as well.

[sschepens]

Yes, there are some race conditions they all come from using DefaultClient and allowing functionallity that should require a new client.
I believe we should add a Client abstraction to goreq and make these things configurable at a global level and allow to create new goreq clients.

[rrh]

any progress on this over the weekend?

[sschepens]

@rrh I haven't had time to check this, but those races are hard to tackle without breaking backwards compatibility, that's a bummer.