Fix racy notificationManager #3714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sredxny
reviewed
Oct 26, 2021
apidef/notifications.go
Outdated
| ContentType: "application/json", | ||
| Body: notification, | ||
| } | ||
| postBody, _ := json.Marshal(notification) |
There was a problem hiding this comment.
would worth to check the error anyway
devsergiy
approved these changes
Oct 28, 2021
vaske
approved these changes
Oct 28, 2021
| defer resp.Body.Close() | ||
| _, errRead := ioutil.ReadAll(resp.Body) | ||
| if errRead != nil { | ||
| log.Error("Request failed, trying again in 10s. Error was: ", err) |
There was a problem hiding this comment.
it's logging err and not errRead. Can we log errRead
There was a problem hiding this comment.
Also can we reuse variable err instead of having new errMarshaling, errRead etc initialised each time
There was a problem hiding this comment.
solved @jeffy-mathew
|
Kudos, SonarCloud Quality Gate passed!
|
jeffy-mathew
approved these changes
Oct 28, 2021
17 tasks
sredxny
pushed a commit
that referenced
this pull request
Jan 2, 2022
* using native http client for notification manager * handling errors in NotificationsManager * fixing errors Co-authored-by: Jeffy Mathew <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using a native
http.ClientforNotificationManagersince the lib we were using (goreq) is archived and has some data race problems franela/goreq#111In this way we avoid random data races related to the
NotificationManagerin our CI pipeline.Related Issue
Motivation and Context
How This Has Been Tested
Screenshots (if appropriate)
Types of changes
Checklist
fork, don't request your
master!masterbranch (left side). Also, you should startyour branch off our latest
master.go mod tidy && go mod vendorgo fmt -sgo vet