net: ngbe: Fix phy mode set to external phy

commit f2916c8 upstream.

The MAC only has add the TX delay and it can not be modified.
MAC and PHY are both set the TX delay cause transmission problems.
So just disable TX delay in PHY, when use rgmii to attach to
external phy, set PHY_INTERFACE_MODE_RGMII_RXID to phy drivers.
And it is does not matter to internal phy.

Fixes: bc2426d ("net: ngbe: convert phylib to phylink")
Signed-off-by: Mengyuan Lou <[email protected]>
Cc: [email protected] # 6.3+
Reviewed-by: Jacob Keller <[email protected]>
Link: https://patch.msgid.link/E6759CF1387CF84C+20240820030425.93003-1-mengyuanlou@net-swift.com
Signed-off-by: Paolo Abeni <[email protected]>
Signed-off-by: mengyuanlou <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

drivers/net/ethernet/wangxun/ngbe/ngbe_mdio.c

@@ -215,10 +215,14 @@ int ngbe_phy_connect(struct wx *wx)
 {
 	int ret;
 
+	/* The MAC only has add the Tx delay and it can not be modified.
+	 * So just disable TX delay in PHY, and it is does not matter to
+	 * internal phy.
+	 */
 	ret = phy_connect_direct(wx->netdev,
 				 wx->phydev,
 				 ngbe_handle_link_change,
-				 PHY_INTERFACE_MODE_RGMII_ID);
+				 PHY_INTERFACE_MODE_RGMII_RXID);
 	if (ret) {
 		wx_err(wx, "PHY connect failed.\n");
 		return ret;