Fix Indeterminate State not Triggered from 'false' state

[vincent-leonardo]

#76

Hi, after tracing the calls of indeterminate toggling I've found the source of this minor bug.
The problems happens with the default checkbox $formatters by angular.

The default checkbox formatters[0] on angular.js:24100

ctrl.$formatters.push(function(value) {
  return equals(value, trueValue);
});

So I did a quick hack to replace the default formatters in initMaybe @ bsSwitch.js

bsSwitch.js:153

controller.$formatters[0] = function(value) {
  if (value === undefined) {
    return value;
  }
  return angular.equals(value, getTrueValue());
}

[frapontillo]

Awesome! Can you please add a test for the false-to-indeterminate switch? Try to cover all edge cases if possible. Thanks!

[vincent-leonardo]

Done. I am not familiar with writing test case with karma (in fact it's the first time I've written one)
I don't use this library extensively, so I might not think of some edge cases.

Btw, I didn't realize indeterminate includes null value as well. Added it.

[frapontillo]

If it is indeterminate, how come the on class is set?

[vincent-leonardo]

I thought that's how your library behaves?
All your test codes were written that way.

[SiobhanBaynes]

Hi guys, Any idea when this will be merged?

[ygilliot]

Since you ( @frapontillo ) validated, all checks have passed and branch has no conflicts, could you please merge to base?

I would prefer using "official" patched version than modifiying code file myself like a savage.
My thanks to @vincent-leonardo for resolving this bug.

[frapontillo]

@ygilliot I'm still not convinced by #121 (comment)

[frapontillo]

@vincent-leonardo can I have an update on this?

[vincent-leonardo]

@frapontillo as I mentioned before, your test cases were written such that in indeterminate state the class will still be on. You can check your original test spec bsSwitchSpec.js:313

[frapontillo]

Thanks @vincent-leonardo!

[vincent-leonardo]

@frapontillo no problem, glad it helps.