Skip to content
This repository has been archived by the owner on Sep 25, 2019. It is now read-only.

fix(challenges): fix description and tests to use sync hashing #125

Merged
merged 1 commit into from
Jul 14, 2018
Merged

fix(challenges): fix description and tests to use sync hashing #125

merged 1 commit into from
Jul 14, 2018

Conversation

ivan3123708
Copy link
Contributor

ISSUES CLOSED: #119

Description

Changed challenge description for password hashing code to use sync method because previous one used async code but didn't handle it correctly.

Pre-Submission Checklist

  • Your pull request targets the dev branch.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/challenge-tests)
  • All new and existing tests pass the command npm test.
  • Use npm run commit to generate a conventional commit message.
    Learn more here: https://conventionalcommits.org/#why-use-conventional-commits
  • The changes were done locally on your machine and NOT GitHub web interface.
    If they were done on the web interface you have ensured that you are creating conventional commit messages.

Checklist:

  • Tested changes locally.
  • Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #119

@scissorsneedfoodtoo scissorsneedfoodtoo merged commit cfa99ef into freeCodeCamp:dev Jul 14, 2018
@scissorsneedfoodtoo
Copy link
Contributor

👍 Awesome! Everything LGTM 👍

Thank you for taking the time to report and creating a PR to fix this issue, @ivan3123708. Looking forward to your next contribution.

@ivan3123708 ivan3123708 deleted the fix/use-sync-hashing branch July 14, 2018 15:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Advanced Node and Express - Hashing Your Passwords - needs refactoring
2 participants