-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to README.md #1151
Changes to README.md #1151
Conversation
As said in the previous PR, this is an awesome place to put this information. My first attempt at PR here, I also closed the request and opened a new one. Several times actually. I think this caused clutter, confusion, and extra work for the grandmasters. Eventually I discovered, you can reopen the initial pr (even if the branch is deleted), rename the title, edit the description, anything, by playing with the buttons on the website. One continuous PR seems to make it easier for the comitter to include the history of the review into the tree. Iirc comments on closed prs didn't send me an email. See this instruction to squash your commits into one with a great log message: I (nobody, mind you, just a hobbyist here) recommend a pr and commit title like, "README.md: Mention image downloads", or "README.md: Link bootable image downloads"... as long as those are <50 characters. I think it was CONTRIBUTING.md that has a great explanation for this. |
Thanks for the knowledge |
Can you squash all these down into one commit? |
README.md
Outdated
@@ -15,6 +15,8 @@ See build(7), config(8), [FreeBSD handbook on building userland](https://docs.fr | |||
For information on the CPU architectures and platforms supported by FreeBSD, see the [FreeBSD | |||
website's Platforms page](https://www.freebsd.org/platforms/). | |||
|
|||
Official FreeBSD bootable images on our [releases page](https://download.freebsd.org/ftp/releases/ISO-IMAGES/) to get yourself one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that the other parts of this file use 'our' or similar 1st-person plural pronouns.
For official FreeBSD bootable images, see our [release page](...)
might be better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it an issue with using "our"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. It's an informal style that doesn't match the rest of the doc.
How would I do that? |
Edit: please correct and forgive me if the syntax of this comment is incorrect style in this community. |
(where BRANCH_NAME is the name of your branch) then you'll have a number of lines in your editor. They will all be I don't think README.md has changed since your pull requests. If it had, you'd need to rebase by doing:
(in this case, just leave what should just be one pick line). Hopefully you'd not have to resolve conflicts. Once you've done all that, you'll need to push it back to GitHub with |
I've done git rebase -i main but the commits are no longer there. It displays noop |
Oh! You're not working on a branch. I hadn't noticed that. You'll need to change |
Landed... I think I closed it wrong though. |
Reviewed by: imp Pull Request: #1151
Reviewed by: imp Pull Request: freebsd/freebsd-src#1151
No changes to source code