bsdinstall: fix ps3 regression #1594
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not using: FREEBSD_BOOTLABEL=$OSNAMEBut after sourcing |
aomsin2526
force-pushed
the
main-ps3-bsdinstall-fix
branch
from
22ae9c2 to
4fdaf77
Compare
Fixed thanks! |
|
That should work right? Aesthetically, I would have placed it closer to |
jlduran
approved these changes
Feb 7, 2025
b6644f5 introduces FREEBSD_BOOTLABEL="FreeBSD" as default value but cc42ef5 removed this line, expecting it to be set by update_uefi_bootentry() But ps3 don't use this function so its broken completely. So we add this line back. Signed-off-by: Chattrapat Sangmanee <[email protected]>
aomsin2526
force-pushed
the
main-ps3-bsdinstall-fix
branch
from
4fdaf77 to
fcee668
Compare
|
I think it should work. I tested my original code and it work fine. I will test this new one tomorrow. Edit: Tested and it works! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b6644f5 introduces FREEBSD_BOOTLABEL="FreeBSD" as default value but cc42ef5 removed this line, expecting it to be set by update_uefi_bootentry()
But ps3 don't use this function so its broken completely.
So we add this line back.
Example /boot/etc/kboot.conf
Bad:
default=='/kernel/kernel kernelname=/boot/kernel/kernel vfs.root.mountfrom=ufs:/dev/da1s2a'Good:
default=FreeBSDFreeBSD='/kernel/kernel kernelname=/boot/kernel/kernel vfs.root.mountfrom=ufs:/dev/da1s2a'