-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not start fullscreen in nonqubes #1134
Conversation
Works as intended in my Ubuntu env, but when I attempt to run the client from this branch in |
9be16e7
to
735af95
Compare
whoops, left out one critical line, fixed! |
LGTM in both environments now, though looks like we have two legit test failures:
and a drop in coverage
|
735af95
to
db95e49
Compare
thanks for the review! yes, showing the main windows needs coverage for both qubes and non-qubes now. this has been updated so we should see ci go green |
Rebased on latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @creviera , LGTM based on test plan:
- Start the client in non-qubes and verify that the client shows up max-window instead of fullscreen
- Start the client in qubes and verify that the client shows up max-window and that Part of the client window is hidden when resized #1109 is not reintroduced
- Test coverage is 100%
Description
Qubick off-sprint PR to no longer start the client in fullscreen.
Test Plan