-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(readme): add architecture diagram #1995
Conversation
Co-authored-by: deeplow <[email protected]>
I've discovered this before as well, and came to the same conclusion. If you look at the first commit to securedrop-log (9ff16b6), the original idea was that clients directly log to the VM via a custom log handler, but that was dropped later on in favor of rsyslog (see freedomofpress/securedrop-log#7 and 29c1cf7), but the old approach was never deleted. |
Also: this is great, will make it very easy to visualize the proposed changes in #1719 once we get there :) |
Thanks for the reassuring confirmation, @legoktm. I've removed the securedrop-client/log/README.md Lines 40 to 41 in a804886
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will hold off on merging so @deeplow has the chance to review too.
(gonna land this, we can always make follow-up changes if it's not accurate) |
Status
Ready for review
Description
@deeplow and I have walked through the
log/
portion of this repository and mapped out:It should be descriptive and uncontroversial, except that we couldn't account for:
securedrop-log
, which nothing in eithersecuredrop-client
orsecuredrop-workstation
appears to invoke; orsecuredrop_log
, which nothing in eithersecuredrop-client
orsecuredrop-workstation
appears to load.Are they remnants of an earlier implementation, before the
securedrop-redis-log → securedrop-log-saver
buffering pipeline and thesd-rsyslog → qrexec securedrop.Log
RPC?