Add functionality for deleting sources #78
Conversation
ultimatecoder
force-pushed
the
master-add-functionality-to-delete-source
branch
from
7dbda8e to
80cd544
Compare
ultimatecoder
force-pushed
the
master-add-functionality-to-delete-source
branch
5 times, most recently
from
f10c39b to
806b230
Compare
ultimatecoder
changed the title
eloquence
changed the title
|
One note so far: The text on this is both a bit small (maybe just my screen?) and gets cut off on the edges.
|
securedrop_client/gui/widgets.py
Outdated
| "<small>This Source will no longer be able to correspond", | ||
| "through the log-in tied to this account.</small>", | ||
| ) | ||
| message = ' <br> '.join(message) |
There was a problem hiding this comment.
I don't know how Qt handles this, but it might be better to not have manual <br>'s but instead get the text to wrap. If possible?
There was a problem hiding this comment.
Removed custom <br> tags. I was using them for exactly replicating the wireframe.
For separating both (large and small) messages, I am unable to find a solution without using a <br> tag. If you have any batter solution, then please suggest. If not, then I request you to resolve the conversation. Thanks!
There was a problem hiding this comment.
I think it's ok to use it to separate the two paragraphs, but I didn't want to use it for formatting each line.
ultimatecoder
force-pushed
the
master-add-functionality-to-delete-source
branch
3 times, most recently
from
6189aca to
447b3f3
Compare
A Source Profile Short menu, which is responsible for displaying Source name and Hamburger Button Menu. Hamburger button menu contains single operation to delete the Source. Resolves: freedomofpress#18
|
@heartsucker Many thanks for reviewing this PR. While improving code according to your comments, I found I have forgotten to launch MessageBox when Delete Source is clicked from menu. I have tried to update that change along with changes you mentioned. I have updated the video to show change of popup and default text wrapping. Please go through it once again. Apologies for that trouble. Have a great day! |
Is this on Qubes OS? For me, it shows correctly. Please verify in the video. |
|
@ultimatecoder Hi Jaysinh: Are you looking to replicate the Qubes style of dialogs? None of the client dialogs should mimic Qubes' UI things. No buttons will have icons on them, no icons/graphics will be used anywhere, unless shown in the wireframes or final mockups. For now, if all things could just get coded to match the wireframes, that'd be great. If this PR is ready to go, please don't worry about fixing those things—as separate Issues will be getting filed for visual styling, and I don't want this note to hold-up getting a PR in. Just FYI. :) |
|
@ninavizz Understood. Thanks! |
|
@ninavizz those glyphs on the buttons are Qt defaults (pretty sure?), and we can override/remove them later. |
|
Awesome job :D |
|
@heartsucker Thanks for guiding, reviewing and merging 😊 |
Description: Adding a functionality to delete a Source when you are a Journalist.
Status: In progress
Fixing: Add support for deleting entire sources #18
How to test?: Pending. Will add as soon as I will complete the work.
Video demonstration of feature:
Outdated YouTube linkYoutube link