Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update screenshots for SecureDrop 1.7.0 #129

Merged
merged 1 commit into from
Jan 12, 2021
Merged

Conversation

eloquence
Copy link
Member

@eloquence eloquence commented Jan 9, 2021

Status

Ready for review

Description of Changes

  • Also fixes wording for "New Identity" instructions
  • Standardizes logo to NYWorld logo (except for the "Change logo"
    page) to reinforce that logo is typically customized

Resolves #121

Note to reviewer

GitHub's "rich diff" on the Files Tab (the button next to <> for each file) is useful for screenshot comparisons.

Checklist (Optional)

  • Doc linting (make docs-lint) passed locally
  • You have previewed (make docs) docs at http://localhost:8000

Copy link
Contributor

@gonzalo-bulnes gonzalo-bulnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heads up: the new version of the file docs/images/manual/screenshots/journalist-admin_system_config_page.png displays a SecureDrop logo. (And it is wider than the other images: 1061px instead of 1024px?)

@eloquence
Copy link
Member Author

eloquence commented Jan 9, 2021

Thanks @gonzalo-bulnes, good catch but intentional in this case: this section of the documentation shows how to change the stock logo to a custom one. (The width inconsistency is the result of these screenshots being taken manually rather than being generated via the functional tests; RTD's CSS will auto-scale them so it shouldn't be noticeably different in practice.)

- Also fixes wording for "New Identity" instructions
- Standardizes logo to NYWorld logo (except for the "Change logo"
  page) to reinforce that logo is typically customized

Resolves #121
@eloquence
Copy link
Member Author

(Rebased.)

Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on visual review.

@zenmonkeykstop zenmonkeykstop merged commit 7c7ed80 into main Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update screenshots for 1.7.0
3 participants