-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add smoketest (package installed, keyring/repo files in place) #9
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small comments about the tests, but overall looks good!
tests/test_keyring.py
Outdated
# Basic acceptance testing for keyring package. | ||
# Expects fedora environment. | ||
|
||
RPM_QUERY_KEYRING_PACKAGE = ["rpm", "-q", "securedrop-workstation-keyring"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless these need to be reused, the tests would be easier to read if the commands were inlined where they get invoked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(reuse it a bit checking multiple different packages, but made it clearer what's happening at invocation)
01cf554
to
fd42eb8
Compare
Thank you for the feedback, if only I had pushed my extra changes bit min sooner! I've added support for running the tests in the container, addressed your comment re test failure, and (wip) adding github action support, although still figuring that part out. I went back and forth about making the build-rpm and smoketest separate github actions, and now I'm inclined to make them separate, so that it's clear what part is failing. It's all kind of overkill for a repo that will hardly ever be updated. opinions welcome. |
(The way I'm trying to shove systemd into the fedora container is unsurprisingly not ideal: |
bbd7f99
to
1d5f760
Compare
…es are present, and key is imported into rpmdb
specify rpm if prebuilt.
4b00bdb
to
2a7ecc8
Compare
092eecb
to
a89bd5b
Compare
Closes #8