Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make grub2-xen-pvh a dependency of dom0 config rpm #1211

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rocodes
Copy link
Contributor

@rocodes rocodes commented Dec 3, 2024

Status

Work in progress (Code-complete but corresponding changes elsewhere are needed, see below)

Description of Changes

Fixes #1063.

Changes proposed in this pull request:
Make grub2-xen-pvh a dependency of the dom0 config rpm.

This requires the rpm to be installed with network access (i.e. qubes-dom0-update instead of via dnf), so it's blocked on the existence of the securedrop-workstation-keyring package, and of the install mechinism of the dom0 config rpm changing to sudo qubes-dom0-update securedrop-workstation-dom0-config.

(Will require workstation CI changes, tbd)

Testing

If you made non-trivial code changes, include a test plan and validated it for this PR.

Deployment

Any special considerations for deployment? Consider both:

  1. Upgrading existing pilot instances
  2. New installs

Checklist

If you have made changes to the provisioning logic

  • All tests (make test) pass in dom0

If you have added or removed files

  • I have updated MANIFEST.in and rpm-build/SPECS/securedrop-workstation-dom0-config.spec

If documentation is required

  • I have opened a PR in the docs repo for these changes, or will do so later
  • I would appreciate help with the documentation

… rpm to be installed with network access (i.e. qubes-dom0-update instead of via dnf).
@rocodes rocodes added the blocked label Dec 3, 2024
@rocodes rocodes mentioned this pull request Jan 10, 2025
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install grub2-xen-pvh in dom0 using rpm dependencies instead of manually
1 participant