Make grub2-xen-pvh a dependency of dom0 config rpm #1211
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Work in progress (Code-complete but corresponding changes elsewhere are needed, see below)
Description of Changes
Fixes #1063.
Changes proposed in this pull request:
Make
grub2-xen-pvh
a dependency of the dom0 config rpm.This requires the rpm to be installed with network access (i.e. qubes-dom0-update instead of via dnf), so it's blocked on the existence of the securedrop-workstation-keyring package, and of the install mechinism of the dom0 config rpm changing to
sudo qubes-dom0-update securedrop-workstation-dom0-config
.(Will require workstation CI changes, tbd)
Testing
If you made non-trivial code changes, include a test plan and validated it for this PR.
Deployment
Any special considerations for deployment? Consider both:
Checklist
If you have made changes to the provisioning logic
make test
) pass indom0
If you have added or removed files
MANIFEST.in
andrpm-build/SPECS/securedrop-workstation-dom0-config.spec
If documentation is required