Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates SecureDrop logo file (for v1.0 style) #354

Merged
merged 2 commits into from
Dec 12, 2019

Conversation

conorsch
Copy link
Contributor

@conorsch conorsch commented Dec 2, 2019

Matches the changes shipped with SecureDrop v1.0.

To perform this update, I simply ran cp ../securedrop/securedrop/static/i/logo.png ./sd-proxy/logo-small.png, with the https://github.com/freedomofpress/securedrop repo cloned adjacent.

Review

Make sure to view the rich diff to evaluate the difference here. The new file is not just the logo, but also contains the "SecureDrop" text beneath it. It should be suitable for now, and likely better already than using the old style.

Matches the changes shipped with SecureDrop v1.0.
@eloquence
Copy link
Member

Make sure to view the rich diff to evaluate the difference here. The new file is not just the logo, but also contains the "SecureDrop" text beneath it

Is this the logo that's shown in the pop-up notifications e.g. during automatic updates, or is it used anywhere else currently? If it's just the notifications, it might be preferable to use the version w/o text, given the small size (cc @ninavizz). If so, I can update accordingly.

@emkll
Copy link
Contributor

emkll commented Dec 5, 2019

@eloquence For now, it is only used for notifications.
before:
popup-icon-old
after:
popup icon

@ninavizz
Copy link
Member

ninavizz commented Dec 5, 2019

OOF... @emkll @conorsch for both this icon and the desktop icon, do y'all need a PNG or SVG? I do need to draft brand guidelines with canonical artwork to reference that are/is all correct, but for now I'd like to offer a Cube-only that is correct (with white lettering/keyhole).

Also, is there a way to use a different version of the icon for the one that Qubes colorizes in the "spaces" menu-thingy at the top, and in the Q menu dropdowns? Sure, I'd rather they just not do that... but until that change potentially happens, I'd like to use monochromatic high-contrast art to improve icon recognition, there. If not, then I'd recommend using the 1-color icon (no white, even, only knockouts), everywhere except the desktop.

+1 to Erik's assertion that it should just be the SD cube, no wording. On an aside, from also seeking to retire the over/under lockup (what's currently shown in the screenshot).

@eloquence
Copy link
Member

I pushed a commit to update it to a version without the wordmark, and with the white cube internals. Let me know what y'all think (thanks to @ninavizz for preparing an asset, which I cropped and resized for this purpose).

@eloquence
Copy link
Member

This is ready for re-review.

@zenmonkeykstop
Copy link
Contributor

zenmonkeykstop commented Dec 11, 2019

make alling now, but in case I forget, the logo will probably also need to be updated in the securedrop-export repo, as it's installed to sd-export repos via a Debian package, not via Salt.

@zenmonkeykstop zenmonkeykstop self-assigned this Dec 11, 2019
Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed new icon in place and used in updater message.

@zenmonkeykstop zenmonkeykstop merged commit e999834 into master Dec 12, 2019
@legoktm legoktm deleted the update-securedrop-logo-to-match-sd-v1 branch May 28, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants