Adds SDW buster template rpm 0.2.3 #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking as draft while I poke at the key-verification tasks in CI... |
added 2 commits
June 9, 2021 17:26
Promoting to prod the same artifact submitted to yum-test in [0]. This RPM is signed with the *new* prod key, as part of the key rotation transition in 2021-06. The new keyid is: 2359E6538C0613E652955E6C188EDD3B7B22E6A3 This is the first artifact on yum.securedrop.org to be signed with this key. [0] freedomofpress/securedrop-yum-test#26
The CI logic explicitly checks that the prod key was used to sign RPMs in this repo. We're currently rotating prod signing keys, so I've added supported for *both* keys to the script. This change doesn't include strict logic about all newer RPMs being signed with the newer key, so humans should still verify the correct key was used, as we get closer to the expiry date. It'll still catch easy mistakes like if the test key is used, since we frequently promote the same debs from yum-test to yum prod.
conorsch
force-pushed
the
sdw-template-0.2.3
branch
from
d5c9f3c to
e445fe1
Compare
|
All set, marking ready for review. |
sssoleileraaa
approved these changes
Jun 10, 2021
There was a problem hiding this comment.
- This is the same rpm submitted in the yum-test PR (above). Grab that locally, run
rpm --delsignon it and on this one, and you should see the same checksum:c419f39319d78bc034b861af315b503454ae69f8bc09201f6410b63125d46d02 - CI is passing, the rpm is properly signed with the prod key
- Visual inspection of changes to the key verification scripts
Closed
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name of package:
qubes-template-securedrop-workstation-busterPromoting to prod the same artifact submitted to yum-test in [0].
This RPM is signed with the new prod key, as part of the key rotation
transition in 2021-06. The new keyid is:
2359E6538C0613E652955E6C188EDD3B7B22E6A3
This is the first artifact on yum.securedrop.org to be signed with this
key.
[0] freedomofpress/securedrop-yum-test#26
Test plan
rpm --delsignon it and on this one, and you should see the same checksum:c419f39319d78bc034b861af315b503454ae69f8bc09201f6410b63125d46d02