expands ARIA-LABELs to add context to recurring UI elements

thread: #6165 (comment) thread: #6165 (comment)
freedomofpress · Dec 13, 2021 · 3995452 · 3995452
1 parent f54157a
commit 3995452
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/securedrop/journalist_templates/account_new_two_factor.html b/securedrop/journalist_templates/account_new_two_factor.html
@@ -22,6 +22,6 @@ <h1>{{ gettext('Enable YubiKey (OATH-HOTP)') }}</h1>
   <input name="csrf_token" type="hidden" value="{{ csrf_token() }}">
   <label for="token">{{ gettext('Verification code') }}</label>
   <input name="token" id="token" type="text" placeholder="123456">
-  <button type="submit" aria-label="{{ gettext('Submit') }}">{{ gettext('SUBMIT') }}</button>
+  <button type="submit" aria-label="{{ gettext('Submit verification code') }}">{{ gettext('SUBMIT') }}</button>
 </form>
 {% endblock %}
diff --git a/securedrop/journalist_templates/admin.html b/securedrop/journalist_templates/admin.html
@@ -92,7 +92,7 @@ <h2 id="users-heading" class="visually-hidden">Users</h2>
 
 <section aria-labelledby="update-instance-config-heading">
 <h2 id="update-instance-config-heading" class="visually-hidden">Update Instance Config</h2>
-<a href="{{ url_for('admin.manage_config') }}" class="btn" id="update-instance-config" aria-label="{{ gettext('Instance Config') }}">
+<a href="{{ url_for('admin.manage_config') }}" class="btn" id="update-instance-config" aria-label="{{ gettext('Update instance config') }}">
   {# FIXME:
   <img src="{{ url_for('static', filename='icons/pencil-alt.png') }}" class="icon" width="15" height="15" alt="">
   #}

diff --git a/securedrop/journalist_templates/admin_new_user_two_factor.html b/securedrop/journalist_templates/admin_new_user_two_factor.html
@@ -24,6 +24,6 @@ <h1>{{ gettext('Enable YubiKey (OATH-HOTP)') }}</h1>
   <input name="csrf_token" type="hidden" value="{{ csrf_token() }}">
   <label for="token">{{ gettext('Verification code') }}</label>
   <input name="token" id="token" type="text" placeholder="123456">
-  <button type="submit" aria-label="{{ gettext('Submit') }}">{{ gettext('SUBMIT') }}</button>
+  <button type="submit" aria-label="{{ gettext('Submit verification code') }}">{{ gettext('SUBMIT') }}</button>
 </form>
 {% endblock %}
diff --git a/securedrop/journalist_templates/col.html b/securedrop/journalist_templates/col.html
@@ -125,7 +125,7 @@ <h2>{{ gettext('Reply') }}</h2>
       {# FIXME:
       <hr class="no-line">
       #}
-      <button id="reply-button" class="button pull-right" type="submit" aria-label="{{ gettext('Submit') }}">{{ gettext('SUBMIT') }}</button>
+      <button id="reply-button" class="button pull-right" type="submit" aria-label="{{ gettext('Submit reply') }}">{{ gettext('SUBMIT') }}</button>
     </form>
   {% else %}
     <p class="notification">{{ gettext("This source has no encryption key.") }}</p>

diff --git a/securedrop/journalist_templates/edit_account.html b/securedrop/journalist_templates/edit_account.html
@@ -30,7 +30,7 @@ <h2 id="change-heading">{{ gettext('Change Name and Admin Status') }}</h2>
       <input name="is_admin" id="is-admin" type="checkbox" {% if user.is_admin %}checked{% endif %}>
       <label for="is-admin">{{ gettext('Is Admin') }}</label>
     </div>
-    <button type="submit" id="update" aria-label="{{ gettext('Update') }}">{{ gettext('UPDATE') }}</button>
+    <button type="submit" id="update" aria-label="{{ gettext('Update account') }}">{{ gettext('UPDATE') }}</button>
   </form>
   </section>
 {% else %}
@@ -48,7 +48,7 @@ <h2 id="change-heading">{{ gettext('Change Name') }}</h2>
       {% set last_name = g.user.last_name or '' %}
       <input name="last_name" id="last_name" value = "{{ last_name }}">
     </div>
-    <button type="submit" id="change-name-button" aria-label="{{ gettext('Update') }}">{{ gettext('UPDATE') }}</button>
+    <button type="submit" id="change-name-button" aria-label="{{ gettext('Update your account') }}">{{ gettext('UPDATE') }}</button>
   </form>
   </section>
 {% endif %}