Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] Tails GUI updater reporting new versions #3426

Closed
conorsch opened this issue May 15, 2018 · 3 comments
Closed

[QA] Tails GUI updater reporting new versions #3426

conorsch opened this issue May 15, 2018 · 3 comments

Comments

@conorsch
Copy link
Contributor

Bug

Description

The 0.7.0 GUI updater reports new versions even when it's running the latest. Just ran a pre-flight check with the 0.7.0 tag, checked out inside a Tails VM. The install portion completed fine. So did ./securedrop-admin tailsconfig. However, after finishing, it popped up the GUI declaring there were new updates. Which there definitely should not be, given that 0.7.0 is the latest release.

After a reboot of the Tails VM, the GUI updater displayed again, prompting to install updates. I accepted. Here's the detailed output: https://gist.github.com/conorsch/2e2da8fb909df067b693949474ef945c

Steps to Reproduce

See above.

Expected Behavior

0.7.0 is determined to be latest release; no further prompting.

Actual Behavior

Prompts for updates even though 0.7.0 is latest release.

Comments

@redshiftzero redshiftzero added this to the 0.7 milestone May 15, 2018
@redshiftzero
Copy link
Contributor

The GUI only appears when ./securedrop-admin check_for_updates reports that updates are needed, so there is something wrong with that logic..

@redshiftzero
Copy link
Contributor

redshiftzero commented May 15, 2018

This extra \n is probably why this is happening:

> /home/amnesia/Persistent/securedrop/admin/securedrop_admin/__init__.py(608)check_for_updates()
-> if current_tag != latest_tag:
(Pdb) latest_tag
'0.7.0'
(Pdb) current_tag
'0.7.0\n'

In hindsight, one way we could have caught this is that the test plan in #3061 should have explicitly included a test for ./securedrop-admin check_for_updates on the latest prod tag.

redshiftzero added a commit that referenced this issue May 15, 2018

Verified

This commit was signed with the committer’s verified signature.
redshiftzero redshiftzero
redshiftzero added a commit that referenced this issue May 15, 2018

Verified

This commit was signed with the committer’s verified signature.
redshiftzero redshiftzero
The issue here was a trailing newline. :-|
@redshiftzero
Copy link
Contributor

redshiftzero commented May 15, 2018

And it turns out we could have added tags locally to confirm this logic was working as expected, see test plan in #3429.

redshiftzero added a commit that referenced this issue May 15, 2018

Verified

This commit was signed with the committer’s verified signature.
redshiftzero redshiftzero
(cherry picked from commit 091234e)
redshiftzero added a commit that referenced this issue May 15, 2018

Verified

This commit was signed with the committer’s verified signature.
redshiftzero redshiftzero
The issue here was a trailing newline. :-|

(cherry picked from commit 2bffcef)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants