Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cffi and argon2_cffi needs update for buiding in Ubuntu 20.04 #5453

Closed
kushaldas opened this issue Aug 17, 2020 · 1 comment · Fixed by #5458
Closed

cffi and argon2_cffi needs update for buiding in Ubuntu 20.04 #5453

kushaldas opened this issue Aug 17, 2020 · 1 comment · Fixed by #5458

Comments

@kushaldas
Copy link
Contributor

kushaldas commented Aug 17, 2020

Description

The current values fail to build on Ubuntu Focal 20.04.

  wrapv -O2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -DUSE__THREAD -DHAVE_SYNC_SYNCHRONIZE -I/usr/include/ffi -I/usr/include/libffi -I/usr/include/python3.8 -c c/_cffi_backend.c -o build/temp.linux-x86_64-3.8/c/_cffi_backend.o", "    c/_cffi_backend.c: In function ‘b_do_dlopen’:", "    c/_cffi_backend.c:4197:31: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]", "     4197 |         *p_printable_filename = PyText_AsUTF8(s);", "          |                               ^", "    c/_cffi_backend.c: In function ‘b_callback’:", "    c/_cffi_backend.c:5911:5: warning: ‘ffi_prep_closure’ is deprecated: use ffi_prep_closure_loc instead [-Wdeprecated-declarations]", "     5911 |     if (ffi_prep_closure(closure, &cif_descr->cif,", "          |     ^~", "    In file included from c/_cffi_backend.c:15:", "    /usr/include/x86_64-linux-gnu/ffi.h:334:1: note: declared here", "      334 | ffi_prep_closure (ffi_closure*,", "          | ^~~~~~~~~~~~~~~~", "    In file included from c/cffi1_module.c:20,", "                     from c/_cffi_backend.c:7370:", "    c/call_python.c: In function ‘_get_interpstate_dict’:", "    c/call_python.c:20:30: error: dereferencing pointer to incomplete type ‘PyInterpreterState’ {aka ‘struct _is’}", "       20 |     builtins = tstate->interp->builtins;", "          |                              ^~", "    error: command 'x86_64-linux-gnu-gcc' failed with exit status 1", "
 

The following two packages should be upgraded:

  • cffi == 1.14.0
  • argon2_cffi == 20.1.0

This is part of #4768 for the package build on Focal

@kushaldas
Copy link
Contributor Author

  • cffi == 1.14.0
  • argon2_cffi == 20.1.0

These two versions can be built on xenial too. I will have to submit a diff-review too.

kushaldas added a commit that referenced this issue Aug 18, 2020
Updates both the releases to the latest, these versions builds
properly on Python3.8 on Ubuntu Focal 20.04
kushaldas added a commit that referenced this issue Aug 20, 2020
Updates both the releases to the latest, these versions builds
properly on Python3.8 on Ubuntu Focal 20.04
emkll added a commit that referenced this issue Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant