-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark unread submissions #1443
Merged
Merged
Mark unread submissions #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psivesely
suggested changes
Nov 8, 2016
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I don't think we need the extra Python functions to accomplish this webapp functionality. Why not just use the
doc.downloaded
attribute? (As a side note, I'm not a fan of how inconsistent naming is in the application--I'd prefer if object references to aSubmission
or array-type ofSubmission
s always used the variable name "submission" or "submissions," unless there is some specific contextual reason not to.) - I think instead of omitting an icon in the case a message has not been received, an open envelope should be included. The empty space feels inconsistent, and the columns shift when the page is refreshed after reading all unread messages, which I think looks poor.
- Similarly, there is now this absent space in rows for outgoing messages. That got me thinking: why not also mark sent messages as read if the source has logged in since they were sent? Since we already expose the rough last login time of each source to the journalists, we might as well inform them if the source has read (or at least had the opportunity to read) their replies. Font Awesome includes
envelope-o
andenvelope-open-o
icons, which would help reinforce the visual distinction between replies and submissions.
700dbe7
to
9964c57
Compare
Also rebased this on develop. Let me know your thoughts @fowlslegs! |
|
psivesely
approved these changes
Nov 15, 2016
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to merge in the work of @mdrose from #1358 which adds in an unread icon on the submissions view for submissions that are unread as well as the option to download all unread messages from the submission view. I broke out the getting unread submissions functionality and added a couple unit tests for it. Let me know if other tests need writing and I will add! Closes #1353.