Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI lint and staging jobs on tbb-0.9.0 #3709

Merged
merged 3 commits into from
Aug 16, 2018
Merged

Conversation

redshiftzero
Copy link
Contributor

@redshiftzero redshiftzero commented Aug 15, 2018

Status

Ready for review

Description of Changes

Fixes #3708

Testing

Do the lint and staging CI jobs pass?

Deployment

CI only

Checklist

If you made changes to the system configuration:

In #3697, we removed the application testing pip dependencies.
This commit updates the testinfra test variables accordingly.
@redshiftzero redshiftzero changed the title [wip] Fix CI staging job on tbb-0.9.0 [wip] Fix CI lint and staging jobs on tbb-0.9.0 Aug 15, 2018
This is temporary until grsec kernels are run in CI
One of these was introduced in #3672, but not discovered due to
other CI failures (e.g. python not found when running the lint job)
@redshiftzero redshiftzero changed the title [wip] Fix CI lint and staging jobs on tbb-0.9.0 Fix CI lint and staging jobs on tbb-0.9.0 Aug 15, 2018
@redshiftzero
Copy link
Contributor Author

Hey @msheiny - this fixes the lint and staging-test-with-rebase CI jobs, take a peek

🚨 Also, after this PR is merged we should no longer allow those CI jobs to break on the tbb-0.9.0 branch 🚨

Copy link
Contributor

@msheiny msheiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌡️ GET A DOCTOR. THIS PR IS ON FIRE

@msheiny msheiny merged commit 52a8ebe into tbb-0.9.0 Aug 16, 2018
@msheiny msheiny deleted the fix-ci-staging-job branch August 16, 2018 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants