Update cwd for show-refs command #3796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When executed in the context of the updater gui, the working directory for the updater script that was called was `/`, resulting in an error stating that the current working directory (or any of its parents) was a git repository. This fix will ensure the SecureDrop updater GUI will not erroneously return a signature verification failure.
redshiftzero
approved these changes
Sep 6, 2018
2 tasks
|
Tested as described, 0.9.0 tag checked out and verified. Looks good |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Fixes #3795
When executed in the context of the updater gui, the working directory for the securedrop-admin script was
/, resulting in an error stating that the current working directory (or any of its parents) was a git repository.This fix will ensure the SecureDrop updater GUI will not erroneously return a signature verification failure.
Testing
Update NowDeployment
Deployed to admin workstations via git, will require admins to manually type
securedrop-admin updateChecklist
If you made changes to the server application code:
make ci-lint) and tests (make -C securedrop test) pass in the development containerIf you made changes to
securedrop-admin:make -C admin test) pass in the admin development containerIf you made non-trivial code changes: