securedrop-config: remove function setting HiddenServiceVersion #4690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For new installs that wish to use v2, the HiddenServiceVersion will be set via the torrc template in the tor-hidden-services Ansible role. For existing installs that still wish to use v2, if they have updated to Xenial, then they already have this HiddenServiceVersion set to 2 in their existing torrc. Installs _not_ on Xenial are no longer supported.
redshiftzero
requested review from
conorsch,
emkll,
kushaldas and
msheiny
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Fixes #4676
For new installs that wish to use v2, the HiddenServiceVersion
will be set via the torrc template in the tor-hidden-services
Ansible role.
For existing installs that still wish to use v2, if they have
updated to Xenial, then they already have this HiddenServiceVersion
set to 2 in their existing torrc. Installs not on Xenial
are no longer supported.
Testing
Mostly inspecting my logic above and agreeing this securedrop-config postinst logic is no longer needed for current installs is what is needed: since this test https://github.com/freedomofpress/securedrop/blob/develop/molecule/testinfra/staging/app/test_tor_hidden_services.py#L84 ensures that the hidden service version is set to 2 for new installs.
Deployment
[covered by main PR description]
Checklist
If you made changes to the system configuration: