Fix scaling of diagrams in docs #4874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #4873
eloquence
requested review from
emkll,
kushaldas,
redshiftzero and
zenmonkeykstop
as code owners
zenmonkeykstop
approved these changes
Oct 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4873
Status
Ready for review.
Testing
I can't easily test the prod rendering, and I don't know why the themes are different between prod and dev. That said, if I manually alter the generated inline styles on docs.securedrop.org in the inspector to the
width:100%that the:width:rule generates in my dev env, the diagrams render correctly with the prod CSS, so this should work, or at the very least have no negative side effects.Workaround taken from readthedocs/sphinx_rtd_theme#630