Add Czech to list of supported languages #4885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contributors: 1000101 Michal Stanke darmozrac michaela-bot updated from: repo: https://github.com/freedomofpress/securedrop-i18n revision: 570f297
Also update the translation-test script so it gets the list of supported locales from i18n_tool.py and will no longer have to be updated when we change that list.
rmol
requested review from
conorsch,
emkll,
heartsucker,
kushaldas and
redshiftzero
as code owners
redshiftzero
reviewed
Oct 9, 2019
redshiftzero
reviewed
Oct 9, 2019
redshiftzero
reviewed
Oct 9, 2019
redshiftzero
approved these changes
Oct 9, 2019
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Fixes #4882.
This adds Czech to the list of supported languages.
Also updates the
translation-testscript so it gets the list of supported locales fromi18n_tool.pyand will no longer have to be updated when we change that list.Testing
cs) is included in theSUPPORTED_LOCALESvariable insecuredrop/config.py. You can edit the file to add it, or simply delete the file and runmake test-config.make devand verify that Czech is an option in the language menu:Deployment
This adds a new supported language. To offer it, sites will need to add it via
securedrop-admin sdconfig, then runsecuredrop-admin install.Checklist
If you made changes to the server application code:
make lint) and tests (make test) pass in the development containerIf you made non-trivial code changes: