Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix column/button alignment problems on source start page #4892

Merged
merged 2 commits into from
Oct 14, 2019

Conversation

rmol
Copy link
Contributor

@rmol rmol commented Oct 9, 2019

Status

Ready for review

Description of Changes

Fixes #4891.

Certain combinations of language and viewport size could result in the two columns on the source start page not lining up with each other. This changes the columns' justify-content property to push the top and bottom containers apart, and controls the borders and content of the buttons to align them better.

Testing

Run make dev and visit the source interface start page. Use the language chooser to confirm that the columns' contents are always in alignment. The header and explanatory text should always start at the top of the column. The buttons should always align at the bottom, and stay the same height.

Resize the browser window, reducing the width until you force a vertical layout. At no point in the horizontal layout should the button text wrap, causing the buttons' heights to differ, nor should the column headings ever appear at different vertical positions (they may wrap).

Deployment

This only affects the UI.

Checklist

If you made changes to the server application code:

  • Linting (make lint) and tests (make test) pass in the development container

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

Certain combinations of language and viewport size could result in the
two columns on the source start page not lining up with each
other. This changes the columns' justify-content property to push the
top and bottom containers apart, and controls the borders and content
of the buttons to align them better.
@eloquence
Copy link
Member

Thanks @rmol, I think we introduced this regression when we were making final tweaks to the spacing. Flagging the spacing changes this PR would introduce (in the English index page) for visibility to @ninavizz:

Before: Screen Shot 2019-10-09 at 16 45 40-fullpage

After: Screen Shot 2019-10-09 at 16 45 33-fullpage

@eloquence eloquence added this to the 1.1.0 milestone Oct 10, 2019
@ninavizz
Copy link
Member

Mmh... not ok with the buttons being that far away from the body blabs. I realize it's only a 5-10px difference between the before and after, but that's just enough to have the buttons start to feel disconnected from the texts above them. If that could be rectified, I'd be most pleased with the PR, otherwise. :)

@rmol
Copy link
Contributor Author

rmol commented Oct 11, 2019

@ninavizz How's this?

image

@eloquence
Copy link
Member

LGTM :)

Before

Screen Shot 2019-10-11 at 14 40 19-fullpage
Screen Shot 2019-10-11 at 14 40 14-fullpage

After

Screen Shot 2019-10-11 at 14 41 03-fullpage
Screen Shot 2019-10-11 at 14 41 08-fullpage

Mobile views

Click to expand

Before

Screen Shot 2019-10-11 at 14 40 17-fullpage
Screen Shot 2019-10-11 at 14 40 22-fullpage

After

Screen Shot 2019-10-11 at 14 41 10-fullpage
Screen Shot 2019-10-11 at 14 41 06-fullpage

Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Approved.

@kushaldas kushaldas merged commit 6357ffb into freedomofpress:develop Oct 14, 2019
emkll added a commit that referenced this pull request Oct 15, 2019
[1.1.0] Fix column/button alignment problems on source start page #4892
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

misalignment on buttons on source interface page
4 participants