Fix column/button alignment problems on source start page #4892
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Fixes #4891.
Certain combinations of language and viewport size could result in the two columns on the source start page not lining up with each other. This changes the columns'
justify-content
property to push the top and bottom containers apart, and controls the borders and content of the buttons to align them better.Testing
Run
make dev
and visit the source interface start page. Use the language chooser to confirm that the columns' contents are always in alignment. The header and explanatory text should always start at the top of the column. The buttons should always align at the bottom, and stay the same height.Resize the browser window, reducing the width until you force a vertical layout. At no point in the horizontal layout should the button text wrap, causing the buttons' heights to differ, nor should the column headings ever appear at different vertical positions (they may wrap).
Deployment
This only affects the UI.
Checklist
If you made changes to the server application code:
make lint
) and tests (make test
) pass in the development containerIf you made non-trivial code changes: