Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Tor Browser from 9.0.2 to 9.0.4 #5095

Merged

Conversation

DrGFreeman
Copy link
Contributor

@DrGFreeman DrGFreeman commented Jan 14, 2020

Status

Ready for review

Description of Changes

Fixes #5094.

Changes proposed in this pull request:

Bump Tor Browser version to 9.0.4 in Dockerfile since 9.0.2 is not available anymore on https://dist.torproject.org/torbrowser and 9.0.4 is the latest version available.
Also taking the opportunity to update download URL from https://www.torproject.org/dist/ to https://dist.torproject.org/.

Testing

How should the reviewer test this PR?

  1. Run functional tests $ securedrop/bin/dev-shell bin/run-test -v tests/functional
    Ensure that the Tor Browser gpg signature verification passes on launch of the container.

Deployment

Any special considerations for deployment? Consider both:

N/A

Checklist

Skipped as per similar change in #5089.

9.0.2 is not available anymore on https://dist.torproject.org/torbrowser
and 9.0.4 is the latest version available.
Also taking the opportunity to update https://www.torproject.org/dist/
to https://dist.torproject.org/.
@DrGFreeman
Copy link
Contributor Author

I should have checked this before but I realized that the Tor Project web site still uses https://www.torproject.org/dist/ for its download links although this redirects to https://dist.torproject.org/. I can add a commit to revert the changes in the download links if preferable.

@zenmonkeykstop
Copy link
Contributor

Hey @DrGFreeman - if you could that'd be great. Probably best to keep using their posted download link in the (admittedly unlikely) event that they change things in the backend.

Revert Tor Browser download link changed in 844ffc4
to the original download link used on the torproject.org website.
Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good based on visual review and confirmation that docker is pulling in the new TBB version. Thanks!

@zenmonkeykstop zenmonkeykstop merged commit 708e498 into freedomofpress:develop Jan 15, 2020
@zenmonkeykstop zenmonkeykstop mentioned this pull request Jan 23, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tor Browser 9.0.2 not available in https://dist.torproject.org/torbrowser/
2 participants