Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add v2 onion service deprecation warning #5366

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Conversation

sssoleileraaa
Copy link
Contributor

Status

Ready for review

Description of Changes

Fixes #5302

  • show the following eol warning for v2 onion services if the source_v3_url file is missing:
Update Required: Your SecureDrop servers are still running v2 Onion Services. In February 2021, v2 Onion Services will be disabled, and your SecureDrop servers may become unreachable.
  • show the following eol warning for v2 onion services if the source_v2_url file exists along with the source_v3_url:
Update Required: Your SecureDrop servers are still running v2+v3 Onion Services. In February 2021, v2 Onion Services will be disabled, and your SecureDrop servers may become unreachable.

Feedback request

Would like review on language here. This is a WIP until we set up the More info redirects. Or perhaps we should create a separate information page in the JI?

Test Plan

  1. Make sure no source_v2_url or source_v3_url files exist in /var/lib/securedrop
  2. Log into the JI in a Tor Browser
  • Verify that the correct v2 warning appears
  1. Add a source_v3_url file in /var/lib/securedrop
  2. Log into the JI in a Tor Browser
  • Verify that no warning appears
  1. Add source_v2_url files in /var/lib/securedrop
  2. Log into the JI in a Tor Browser
  • Verify that the correct v2+v3 warning appears

@eloquence
Copy link
Member

A redirect on https://securedrop.org/v2-onion-eol to our current v2/v3 docs is now live. We can update that section of the docs with more info re: the deprecation timeline as part of 1.5.0.

@sssoleileraaa
Copy link
Contributor Author

tis ready

@zenmonkeykstop zenmonkeykstop self-assigned this Jul 13, 2020
Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in staging env - test plan passed with no issues.

Change looks good to me, approving!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add deprecation notice for v2 services
4 participants