Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prune old, unreachable code and images #5394

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Prune old, unreachable code and images #5394

merged 1 commit into from
Jul 30, 2020

Conversation

eloquence
Copy link
Member

@eloquence eloquence commented Jul 21, 2020 •
edited by conorsch
Loading

Status

Ready for review

Description of Changes

  • Removes old, unreachable "custom header image" logic which was replaced with custom logo upload feature
  • Removes old, 0.3 era backup script and backup variable from staging.yml
  • Removes old logo images and AppArmor whitelisting rules for them

Resolves #5347

Testing

  • Spin up a development environment from this branch and ensure that custom logo functionality still works as expected
  • Examine the removed code paths and verify that they are indeed not callable

Deployment

  • None as far as I can tell. Even if 0.3 era installs that once used this functionality still exist, it would have stopped working a long time ago.

Checklist

  • Waiting for CI to do its thing
  • I have written a test plan and validated it for this PR

@conorsch conorsch self-assigned this Jul 29, 2020
@eloquence eloquence added this to the 1.6.0 milestone Jul 29, 2020
@eloquence
Prune old, unreachable code and images
82b4476 
- Removes old, unreachable "custom header image" logic which was
  replaced with custom logo upload feature
- Remove old, 0.3 era backup script and backup variable from staging.yml
- Remove old logo images and AppArmor whitelisting rules for them

Resolves #5347
@eloquence eloquence force-pushed the 5347-prune-old-code branch from 75151d0 to 82b4476 Compare July 30, 2020 16:38
conorsch
conorsch approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@conorsch conorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Local dev environment still updates logo changes just fine. Thanks for taking the time, @eloquence

@conorsch conorsch merged commit 709b7aa into develop Jul 30, 2020
@legoktm legoktm deleted the 5347-prune-old-code branch January 9, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conorsch conorsch conorsch approved these changes

@emkll emkll Awaiting requested review from emkll

@kushaldas kushaldas Awaiting requested review from kushaldas

@redshiftzero redshiftzero Awaiting requested review from redshiftzero

Assignees

@conorsch conorsch

Labels
None yet
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

Remove CUSTOM_HEADER_IMAGE legacy code
2 participants
@eloquence @conorsch